Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional country query param for /Employees/{alias} #133

Closed
wants to merge 1 commit into from

Conversation

mathiazom
Copy link
Contributor

Closes #132

Makes the country query param optional for /Employees/{alias}, similar to the /Employees endpoint.

with query param

image

without query param

image

with non-matching query param

image

@mathiazom mathiazom requested a review from a team as a code owner October 28, 2024 10:50
@mathiazom mathiazom requested review from nikolaia and trulshj October 28, 2024 10:50
@mathiazom
Copy link
Contributor Author

Is there a reason for requiring the country parameter? Are the email aliases only unique within each country?

@mathiazom
Copy link
Contributor Author

Let's leave this as required, since we don't have an explicit requirement that aliases should be unique across countries.

@mathiazom mathiazom closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optional country query param for /employees/{alias}
1 participant