Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3 - feat: add employee list filters #884

Merged
merged 11 commits into from
Nov 20, 2024
Merged

V3 - feat: add employee list filters #884

merged 11 commits into from
Nov 20, 2024

Conversation

trulshj
Copy link
Contributor

@trulshj trulshj commented Nov 19, 2024

Filters er på plass, mangler søkefelt for navn, tall for antall per kategori lå ikke i design, men Sindre og Andreas mente det var nice

image

Copy link

vercel bot commented Nov 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
variant-no ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 10:22am
variant-se-2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 10:22am

| "Project Management"
| "Design"
| "Utvikling"
| "Administasjon";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should utvikling and administrasjon be replaced with english terms?

Copy link
Contributor

@anemne anemne Nov 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The language should ideally match the selected lang: Norwegian for "no," English for "en," and Swedish for "se"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disse er det som kommer fra Chewbacca, kan brukes som nøkler i oversetting

Copy link
Contributor

@anemne anemne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only a few comments regarding translations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants