Add support for sandboxed socket path #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 1, 2022 18:46
`usize` is made exactly for this (e.g.: the size of a buffer), and signatures are a bit more idiomatic. These changes also try to cast the u32 to a usize as soon as we read it, and will panic if there is an issue (whereas using `as usize` may result in silent conversion errors on uncommon architectures.
Rather than try a single path, try all supported paths, in the preferred order. This avoids breaking compatibility with previous KeePassXC versions. See: keepassxreboot/keepassxc#8018 Fixes: varjolintu#8 Supercedes: varjolintu#7
|
Oh, I had dda48b6 in the same branch, lemme know if you'd prefer to review this separately. |
|
Thank you. I haven't been updating the repo for a while. I really appreciate the help! |
|
You're welcome! I found this simple proxy implementation nice and easy to read, which was a great way to understand how KP and the browser communicate. My intention is to make a few other changes, so we can use something like |
|
This is backwards-compatible and works with both previous versions of KPXC and with the Anything blocking this from being merged? I can move dda48b6 onto a separate PR if you dislike the scope-creep of it. |
varjolintu
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than try a single path, try all supported paths, in the preferred
order. This avoids breaking compatibility with previous KeePassXC
versions.
See: keepassxreboot/keepassxc#8018
Fixes: #8
Supercedes: #7