Recommended Way to Shutdown Varlink Server? #25
Comments
|
I was thinking about passing in an Would you be open to a PR for that? |
|
just return |
|
rust/examples/more/src/main.rs Lines 163 to 166 in 81463ba |
haraldh
added a commit
to haraldh/varlink-rust
that referenced
this issue
Nov 15, 2019
Factor out the `varlink::listen` parameters into a `varlink::ListenConfig` struct,
so we can use ..Default::default().
Add an `stop_listening: Option<Arc<AtomicBool>>` to the `varlink::ListenConfig` struct,
which can be set remotely to break the `varlink::listen` loop.
Stop the running server after 10 seconds
```rust
use std::{thread, time};
use std::sync::atomic::Ordering;
let stop_listening = Arc::new(std::sync::atomic::AtomicBool::new(false));
let child = {
let stop_running = stop_listening.clone();
thread::spawn(move || {
thread::sleep(time::Duration::from_secs(10));
// Stop the running server after 10 seconds
stop_listening.store(true, Ordering::Relaxed);
})
};
varlink::listen(
service,
&address,
&varlink::ListenConfig {
idle_timeout: timeout,
stop_listening: Some(stop_listening),
..Default::default()
},
)?;
child.join().expect("Error joining thread");
```
Obsoletes varlink#26
Addresses varlink#25
|
What do you think about PR #27 ?? |
haraldh
added a commit
to haraldh/varlink-rust
that referenced
this issue
Nov 18, 2019
Factor out the `varlink::listen` parameters into a `varlink::ListenConfig` struct,
so we can use ..Default::default().
Add an `stop_listening: Option<Arc<AtomicBool>>` to the `varlink::ListenConfig` struct,
which can be set remotely to break the `varlink::listen` loop.
Stop the running server after 10 seconds
```rust
use std::{thread, time};
use std::sync::atomic::Ordering;
let stop_listening = Arc::new(std::sync::atomic::AtomicBool::new(false));
let child = {
let stop_running = stop_listening.clone();
thread::spawn(move || {
thread::sleep(time::Duration::from_secs(10));
// Stop the running server after 10 seconds
stop_listening.store(true, Ordering::Relaxed);
})
};
varlink::listen(
service,
&address,
&varlink::ListenConfig {
idle_timeout: timeout,
stop_listening: Some(stop_listening),
..Default::default()
},
)?;
child.join().expect("Error joining thread");
```
Obsoletes varlink#26
Addresses varlink#25
haraldh
added a commit
to haraldh/varlink-rust
that referenced
this issue
Nov 18, 2019
Factor out the `varlink::listen` parameters into a `varlink::ListenConfig` struct,
so we can use ..Default::default().
Add an `stop_listening: Option<Arc<AtomicBool>>` to the `varlink::ListenConfig` struct,
which can be set remotely to break the `varlink::listen` loop.
Stop the running server after 10 seconds
```rust
use std::{thread, time};
use std::sync::atomic::Ordering;
let stop_listening = Arc::new(std::sync::atomic::AtomicBool::new(false));
let child = {
let stop_running = stop_listening.clone();
thread::spawn(move || {
thread::sleep(time::Duration::from_secs(10));
// Stop the running server after 10 seconds
stop_listening.store(true, Ordering::Relaxed);
})
};
varlink::listen(
service,
&address,
&varlink::ListenConfig {
idle_timeout: timeout,
stop_listening: Some(stop_listening),
..Default::default()
},
)?;
child.join().expect("Error joining thread");
```
Obsoletes varlink#26
Addresses varlink#25
haraldh
added a commit
to haraldh/varlink-rust
that referenced
this issue
Nov 18, 2019
Factor out the `varlink::listen` parameters into a `varlink::ListenConfig` struct,
so we can use ..Default::default().
Add an `stop_listening: Option<Arc<AtomicBool>>` to the `varlink::ListenConfig` struct,
which can be set remotely to break the `varlink::listen` loop.
Stop the running server after 10 seconds
```rust
use std::{thread, time};
use std::sync::atomic::Ordering;
let stop_listening = Arc::new(std::sync::atomic::AtomicBool::new(false));
let child = {
let stop_running = stop_listening.clone();
thread::spawn(move || {
thread::sleep(time::Duration::from_secs(10));
// Stop the running server after 10 seconds
stop_listening.store(true, Ordering::Relaxed);
})
};
varlink::listen(
service,
&address,
&varlink::ListenConfig {
idle_timeout: timeout,
stop_listening: Some(stop_listening),
..Default::default()
},
)?;
child.join().expect("Error joining thread");
```
Obsoletes varlink#26
Addresses varlink#25
haraldh
added a commit
that referenced
this issue
Nov 18, 2019
Factor out the `varlink::listen` parameters into a `varlink::ListenConfig` struct,
so we can use ..Default::default().
Add an `stop_listening: Option<Arc<AtomicBool>>` to the `varlink::ListenConfig` struct,
which can be set remotely to break the `varlink::listen` loop.
Stop the running server after 10 seconds
```rust
use std::{thread, time};
use std::sync::atomic::Ordering;
let stop_listening = Arc::new(std::sync::atomic::AtomicBool::new(false));
let child = {
let stop_running = stop_listening.clone();
thread::spawn(move || {
thread::sleep(time::Duration::from_secs(10));
// Stop the running server after 10 seconds
stop_listening.store(true, Ordering::Relaxed);
})
};
varlink::listen(
service,
&address,
&varlink::ListenConfig {
idle_timeout: timeout,
stop_listening: Some(stop_listening),
..Default::default()
},
)?;
child.join().expect("Error joining thread");
```
Obsoletes #26
Addresses #25
|
The above PR was merged 4 years ago, why is this issue still open? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is there a recommended way to shutdown the Varlink server when it is started with
varlink::listen()?I'm sure I could find a way to do it if I implemented the server myself, I was just making sure that there wasn't already a good way to do it.
Specifically I am looking to be able to shutdown the server in response to an RPC call, if that changes anything.
The text was updated successfully, but these errors were encountered: