Bump MSRV #101
Merged
Bump MSRV #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haraldh
approved these changes
Mar 13, 2024
Pull Request Test Coverage Report for Build 8282469423Details
💛 - Coveralls |
haraldh
approved these changes
Mar 13, 2024
|
@haraldh Thanks. What's with the CI? 🤔 |
|
Not sure where these checks are coming from:
|
Ah, @haraldh you need to reselect the required workflows from the settings. |
|
Please gpg sign your commits :-) |
Signed-off-by: Zeeshan Ali Khan <zeenix@gmail.com>
Fixes a clippy warning:
```rust
warning: redundant guard
--> varlink/src/server.rs:593:40
|
593 | ... Ok(buf) if buf.is_empty() => break,
| ^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards
= note: `#[warn(clippy::redundant_guards)]` on by default
help: try
|
593 - Ok(buf) if buf.is_empty() => break,
593 + Ok([]) => break,
|
warning: `varlink` (lib test) generated 1 warning
```
Signed-off-by: Zeeshan Ali Khan <zeenix@gmail.com>
Fixes clippy warning:
```rust
warning: useless use of `vec!`
--> varlink-cli/src/watchclose_epoll.rs:157:21
|
157 | let mut v = vec![Event { events: 0, data: 0 }, Event { events: 0, data: 1 }];
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[Event { events: 0, data: 0 }, Event { events: 0, data: 1 }]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
= note: `#[warn(clippy::useless_vec)]` on by default
```
Signed-off-by: Zeeshan Ali Khan <zeenix@gmail.com>
auto-merge was automatically disabled
March 14, 2024 14:30
Head branch was pushed to by a user without write access
Ughhh, ok. |
|
or, let me remove this hurdle, before development stalls |
For this PR, I already signed the commits. Can you please approve again for the ci? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.