all: Port from chainerror to thiserror
#114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latter is quite ubiquitous in the Rust ecosystem so let's use that. Warning: This is a breaking change so the semver versions should be bumped.
Pull Request Test Coverage Report for Build 12069714020Details
💛 - Coveralls |
cgwalters
reviewed
Dec 2, 2024
| @@ -26,14 +25,12 @@ pub type Result<T> = std::result::Result<T, Box<dyn std::error::Error + 'static | |||
| fn varlink_format(filename: &str, line_len: Option<&str>, should_colorize: bool) -> Result<()> { | |||
| let mut buffer = String::new(); | |||
| File::open(Path::new(filename)) | |||
| .context(format!("Failed to open '{}'", filename))? | |||
| .map_err(|e| format!("Failed to open '{filename}': {e}"))? | |||
There was a problem hiding this comment.
This is fine, though I think using anyhow (and keeping .context) is more ergonomic than this map_err.
There was a problem hiding this comment.
True, in the apps we should use anyhow. I should have waited longer for your review. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latter is quite ubiquitous in the Rust ecosystem so let's use that.
Warning: This is a breaking change so the semver versions are also being bumped.