esi: Implement <esi:include onerror="continue"/> #3767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nigoroll
reviewed
Jan 3, 2022
nigoroll
approved these changes
Jan 3, 2022
|
bugwash: also gate this feature behind a feature flag in trunk. |
|
Rebased against master, added a feature flag. |
bsdphk
reviewed
Jan 4, 2022
|
bugwash: OK once all markers are in the |
This changes the default behavior of includes, matching the ESI language specification. The onerror attribute seems to only accept one value, so in its absence a failed ESI fragment delivery aborts the top request delivery. This new behavior requires the esi_include_onerror feature flag to be raised to take effect. In addition, it breaks the ESI object attribute format for persisted caches.
|
For reference: 582ded6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the default behavior of includes, matching the ESI language specification. The onerror attribute seems to only accept one value, so in its absence a failed ESI fragment delivery aborts the top request delivery.
In addition, it breaks the ESI object attribute format for persisted caches.
This is OK for trunk to change the default behavior and objattr format, but for the 6.0 LTS branch we would need to gate this behind a feature flag. I'm wondering whether this is fine to have such an
esi_include_onerrorflag in 6.0 that does not exist in trunk.