-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backtrace improvements for utilities #4116
base: master
Are you sure you want to change the base?
Conversation
This is useful when printing a backtrace into a fixed size buffer. Suggested-by: Dridi Boukelmoune <dridi.boukelmoune@gmail.com> Signed-off-by: Asad Sajjad Ahmed <asadsa@varnish-software.com>
Signed-off-by: Asad Sajjad Ahmed <asadsa@varnish-software.com>
Signed-off-by: Asad Sajjad Ahmed <asadsa@varnish-software.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The second patch is easier to review with the --ignore-all-space
option (or ?w=1
query string on github).
Signed-off-by: Asad Sajjad Ahmed <asadsa@varnish-software.com>
bugwash: we should enable back-traces outside of The developer mode should always be assumed by |
Bumping this. I assume this can be merged after a rebase? |
I think @bsdphk insisted that we do not make this the default, that it should be controlled in So I don't think it was acceptable as-is. |
This PR adds a default back-trace to all asserts outside of varnishd, e.g., varnishstat.
Also add back-trace to varnishtest asserts.
Example (artificially crafted asserts):
Before:
After:
Before:
After