Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re #4232
Adding earlier overflow checks is pretty easy if we use VCL failure, but so far we had centralized the overflow handling on the client side in the
vtr_deliver_f
, sending downstream a 500 error and not a 503.So my main question is: If we want consistency here, can we settle on simply handling workspace overflows as VCL failures? Or do we really want the separate error code still? If we do, improving the overflow detection on the backend side might become a bit more involved, because right now the backend side error just turns into a 503 on the client side.
Note that this PR is really for discussing the design questions, it does not pass the test suite because of the changed error code.