Add array-based syntax for namespaced headless policies #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before to namespace headless policy we needed to use following syntax: authorize :'project/dashboard' Now we can use array to specify each constant separately so it looks cleaner authorize [:project, :dashboard]
|
Looks good to me, I'm 👍 on this addition. It's the same as in Rails, where |
|
I'd love for this to be included at some point. |
| @@ -44,6 +44,8 @@ def find | |||
| object | |||
| elsif object.is_a?(Symbol) | |||
| object.to_s.classify | |||
| elsif object.is_a?(Array) | |||
| object.map(&:to_s).join('/').to_s.classify | |||
There was a problem hiding this comment.
Can't this be put more simply as: object.join('/') since to_s is implicitly called or am I missing something?
2.2.0 :001 > [:a, :b].join('/')
=> "a/b"
2.2.0 :002 > class Foo
2.2.0 :003?> end
=> nil
2.2.0 :004 > [Foo.new, :b].join('/')
=> "#<Foo:0x007f861a1686e8>/b"
ghost
merged commit 
|
Merged! Thank you, nice idea :) |
|
It actually just occurred to me. Can this be extended to allow truly namespaced policies? Something like |
Closed
|
Will namespacing be extended to the policy_scope method, @jnicklas? |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before to namespace headless policy we needed to use following syntax:
Now we can use array to specify each constant separately so it looks cleaner