Revert "Merge pull request #625 from holyketzer/custom-messages" #684
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting this because it's blocking us from making a new release, see: #656 (comment)
Additionally, me and @dgmstuart have backtracked a bit and believe that in case you'd like to use a solution similar to this then you should probably use specialized error classes instead, something similar to this:
All that said, I believe that the reasoning in #654 is sound, and so query methods should strive towards returning truthy/falsy as opposed to raising errors to deal with custom error messages.