Prevent usage of only: filter for limiting after_action filter
#788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The usage of an `only:` filter works because of Rails new policy `config.action_controller.raise_on_missing_callback_actions = true` not very well.
a-nickol
changed the title
only: filter for controller filteronly: filter for limit after_action filter
a-nickol
changed the title
only: filter for limit after_action filteronly: filter for limiting after_action filter
Burgestrand
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with Rails 7.1 a new security check has been added; it checks whether referenced actions do exist for a given filter. (https://guides.rubyonrails.org/configuring.html#config-action-controller-raise-on-missing-callback-actions)
Because we cannot guaranty that all controller have a index method, the given example in the readme of Pundit for a
after_actionchecking the usage of the lib will raise exceptions in a default rails application.This Pull requests changes the code example to use just a normal if statement to check the given
action_name.