Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Pundit::SUFFIX to Pundit::PolicyFinder::SUFFIX #835

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

Burgestrand
Copy link
Member

This sprung out of #834.

We keep the old constant as an alias for backwards-compatibility.

To do

  • I have read the contributing guidelines.
  • I have added relevant tests.
  • I have adjusted relevant documentation.
  • I have made sure the individual commits are meaningful.
  • I have added relevant lines to the CHANGELOG.

PS: Thank you for contributing to Pundit ❤️

@Burgestrand Burgestrand force-pushed the kbs/move-suffix-to-its-owner branch 3 times, most recently from bc40b82 to 80e4226 Compare October 11, 2024 07:34
@Burgestrand Burgestrand force-pushed the kbs/code-janitoring branch 2 times, most recently from ba324e4 to e296e83 Compare October 11, 2024 07:57
It's only used by the PolicyFinder, so it belongs in there.
@Burgestrand Burgestrand self-assigned this Oct 11, 2024
Base automatically changed from kbs/code-janitoring to main October 11, 2024 08:42
@Burgestrand Burgestrand marked this pull request as ready for review October 11, 2024 08:42
@Burgestrand Burgestrand merged commit 2b0ca28 into main Oct 24, 2024
17 checks passed
@Burgestrand Burgestrand deleted the kbs/move-suffix-to-its-owner branch October 24, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant