Fixed bug when commas are inside queries #31
Conversation
| req_q.split(',').forEach(i => (q[i.split(':')[0]] = i.split(':')[1])); | ||
| req_q.split(',') | ||
| .reduce((acc, curr) => { | ||
| curr.includes(":") ? acc.push(curr) : acc[acc.length - 1] += ("," + curr); |
There was a problem hiding this comment.
This may just be my personal opinion or preference, but I would like to see an explanation for this logic, so other contributors don't need to reverse engineer it.
There was a problem hiding this comment.
Let's say the query is name:Hello, Jsonbox,age:>15. Normally, this would be split up into this array ["name:Hello", "Jsonbox", "age:>15" ]. This isn't the right array and the reduce function solves this, by iterating over the false array. If the element in the array includes a :, the reduce function leaves it untouched, otherwise the reduce function appends the element to the previous one.
Dunno what's so hard to understand about it, much of the codebase is written in similiar way without any comments.
|
@BastianKubaile Now it will still be not working if we want to search a string with |
Fixes #28. The idea is from @tmokenc, but his solution wasn't bug free. This code should work.