Skip to content
This repository has been archived by the owner on Jan 29, 2023. It is now read-only.

Use material bottom navigation #360

Merged
merged 5 commits into from
Oct 25, 2020
Merged

Use material bottom navigation #360

merged 5 commits into from
Oct 25, 2020

Conversation

vase4kin
Copy link
Owner

Please add the details below:

@vase4kin vase4kin added this to the 1.52.4 milestone Oct 10, 2020
@codecov
Copy link

codecov bot commented Oct 25, 2020

Codecov Report

Merging #360 into dev will decrease coverage by 7.23%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #360      +/-   ##
============================================
- Coverage     77.79%   70.55%   -7.24%     
+ Complexity     1874     1690     -184     
============================================
  Files           324      324              
  Lines          6259     6242      -17     
  Branches        461      456       -5     
============================================
- Hits           4869     4404     -465     
- Misses         1046     1517     +471     
+ Partials        344      321      -23     
Impacted Files Coverage Δ Complexity Δ
...in/teamcityapp/home/presenter/HomePresenterImpl.kt 37.69% <16.66%> (-45.52%) 15.00 <1.00> (-23.00)
...teamcityapp/app_navigation/BottomNavigationView.kt 64.10% <70.83%> (-33.86%) 0.00 <0.00> (ø)
...in/teamcityapp/app_navigation/AppNavigationItem.kt 100.00% <100.00%> (ø) 2.00 <2.00> (ø)
.../vase4kin/teamcityapp/agents/view/AgentsAdapter.kt 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
.../vase4kin/teamcityapp/home/data/HomeDataManager.kt 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...se4kin/teamcityapp/home/data/FilterAppliedEvent.kt 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
.../teamcityapp/agents/view/AgentViewHolderFactory.kt 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...mcityapp/favorites/tracker/FavoritesTrackerImpl.kt 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...tyapp/agents/extractor/AgentsValueExtractorImpl.kt 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...app/runningbuilds/data/RunningBuildsDataManager.kt 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 260d5a4...798949c. Read the comment docs.

@vase4kin vase4kin marked this pull request as ready for review October 25, 2020 04:23
@vase4kin vase4kin merged commit 3170241 into dev Oct 25, 2020
@vase4kin vase4kin deleted the dev-material-bottom-nav branch October 25, 2020 04:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant