Skip to content
This repository has been archived by the owner on Jan 29, 2023. It is now read-only.

Fix about list bug #363

Merged
merged 1 commit into from
Nov 11, 2020
Merged

Fix about list bug #363

merged 1 commit into from
Nov 11, 2020

Conversation

vase4kin
Copy link
Owner

Please add the details below:

@vase4kin vase4kin added the bug label Nov 11, 2020
@vase4kin vase4kin added this to the 1.52.4 milestone Nov 11, 2020
@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #363 (0521745) into dev (260d5a4) will decrease coverage by 7.19%.
The diff coverage is 72.05%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #363      +/-   ##
============================================
- Coverage     77.79%   70.60%   -7.20%     
+ Complexity     1874     1694     -180     
============================================
  Files           324      324              
  Lines          6259     6245      -14     
  Branches        461      454       -7     
============================================
- Hits           4869     4409     -460     
- Misses         1046     1516     +470     
+ Partials        344      320      -24     
Impacted Files Coverage Δ Complexity Δ
...in/teamcityapp/home/presenter/HomePresenterImpl.kt 37.69% <16.66%> (-45.52%) 15.00 <1.00> (-23.00)
...n/java/teamcityapp/features/about/AboutFragment.kt 84.66% <66.66%> (+1.42%) 9.00 <2.00> (ø)
...teamcityapp/app_navigation/BottomNavigationView.kt 64.10% <70.83%> (-33.86%) 0.00 <0.00> (ø)
...n/java/teamcityapp/features/about/AboutActivity.kt 87.09% <80.00%> (-12.91%) 6.00 <2.00> (+2.00) ⬇️
...in/teamcityapp/app_navigation/AppNavigationItem.kt 100.00% <100.00%> (ø) 2.00 <2.00> (ø)
...app/features/about/repository/models/ServerInfo.kt 100.00% <100.00%> (ø) 3.00 <3.00> (+2.00)
.../vase4kin/teamcityapp/agents/view/AgentsAdapter.kt 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
.../vase4kin/teamcityapp/home/data/HomeDataManager.kt 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...se4kin/teamcityapp/home/data/FilterAppliedEvent.kt 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
.../teamcityapp/agents/view/AgentViewHolderFactory.kt 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3170241...0521745. Read the comment docs.

@vase4kin vase4kin marked this pull request as ready for review November 11, 2020 14:08
@vase4kin vase4kin merged commit 816a23e into dev Nov 11, 2020
@vase4kin vase4kin deleted the dev-fix-about-list-bug branch November 11, 2020 14:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant