Skip to content

Commit

Permalink
ci: change the build to be verbose by default
Browse files Browse the repository at this point in the history
Previously CI would use a non-verbose build (where exact compilation
and linking commands are not visible) and only if it fails, would
rerun the build in verbose mode.

Change this to use verbose in the initial build as well for two reasons:
1. It is useful to be able to see the exact compilation and linking
   commands even for successful builds, to e.g. confirm some particular
   flags are (not) used as expected.
2. In failed builds, if the failure is during linking, the repeated
   verbose build may not show a single compilation command because all
   files are already compiled, so compilation flags will remain hidden.
  • Loading branch information
vasild committed Jan 7, 2025
1 parent 433412f commit 01264fc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ci/test/03_test_script.sh
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ fi

bash -c "cmake -S $BASE_ROOT_DIR $BITCOIN_CONFIG_ALL $BITCOIN_CONFIG || ( (cat $(cmake -P "${BASE_ROOT_DIR}/ci/test/GetCMakeLogFiles.cmake")) && false)"

bash -c "cmake --build . $MAKEJOBS --target all $GOAL" || ( echo "Build failure. Verbose build follows." && cmake --build . --target all "$GOAL" --verbose ; false )
bash -c "cmake --build . $MAKEJOBS --target all $GOAL --verbose" || ( echo "Build failure. Non-parallel build follows." && cmake --build . --target all "$GOAL" --verbose ; false )

bash -c "${PRINT_CCACHE_STATISTICS}"
du -sh "${DEPENDS_DIR}"/*/
Expand Down

0 comments on commit 01264fc

Please sign in to comment.