fix(proxy/backup.importVmBackup): only dispose resources at the end #7152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathieuRA
approved these changes
Nov 6, 2023
fbeauchamp
approved these changes
Nov 6, 2023
Fixes #7052 Fixes zammad#17383 When a stream is returned, the handler immediately returned a stream which disposed the resource. Due to the disposable having a 5 mins debounce delay, the problem was only apparent after 5 mins.
julien-f
force-pushed
the
fix-proxy-restore
branch
from
692354b to
396a842
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT SQUASH, review by commits.
Description
Fixes #7052
Fixes zammad#17383
When a stream is returned, the handler immediately returned a stream which disposed the resource.
Due to the disposable having a 5 mins debounce delay, the problem was only apparent after 5 mins.
Checklist
Fixes #007,See xoa-support#42,See https://...)Introduced byCHANGELOG.unreleased.md