Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(xo-web/menu): do not subscribe to unhealthy vdi chains if no permissions #7265

Merged
merged 3 commits into from
Jan 3, 2024
Merged

fix(xo-web/menu): do not subscribe to unhealthy vdi chains if no permissions #7265

merged 3 commits into from
Jan 3, 2024

Conversation

OlivierFL
Copy link
Collaborator

Description

Menu : don't subscribe to unhealthy VDI chains if user has not enough permissions

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@OlivierFL OlivierFL self-assigned this Dec 27, 2023
@OlivierFL OlivierFL force-pushed the xo5/unhealthyvdi-chains-subscription-permissions branch from cf981e3 to 471ff7a Compare December 27, 2023 09:22
@OlivierFL OlivierFL requested a review from MathieuRA December 27, 2023 09:26
@MathieuRA MathieuRA requested a review from julien-f December 27, 2023 10:35
@OlivierFL OlivierFL force-pushed the xo5/unhealthyvdi-chains-subscription-permissions branch from 60b4ab0 to a18bb4d Compare December 27, 2023 15:47
julien-f
julien-f reviewed Jan 2, 2024
View reviewed changes
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
@OlivierFL OlivierFL force-pushed the xo5/unhealthyvdi-chains-subscription-permissions branch from a18bb4d to 97078b3 Compare January 2, 2024 13:51
julien-f
julien-f reviewed Jan 3, 2024
View reviewed changes
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
@OlivierFL OlivierFL force-pushed the xo5/unhealthyvdi-chains-subscription-permissions branch from 97078b3 to 01f996c Compare January 3, 2024 17:01
@OlivierFL OlivierFL force-pushed the xo5/unhealthyvdi-chains-subscription-permissions branch from 01f996c to 0f84c40 Compare January 3, 2024 17:03
@OlivierFL OlivierFL requested a review from julien-f January 3, 2024 17:03
@julien-f julien-f merged commit 8b0b2d7 into master Jan 3, 2024
1 check passed
@julien-f julien-f deleted the xo5/unhealthyvdi-chains-subscription-permissions branch January 3, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathieuRA MathieuRA MathieuRA approved these changes

@julien-f julien-f Awaiting requested review from julien-f

Assignees

@OlivierFL OlivierFL

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OlivierFL @julien-f @MathieuRA