Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(web stack): add new ESLint Vue rules #6 #7738

Merged
merged 3 commits into from
Jun 20, 2024
Merged

chore(web stack): add new ESLint Vue rules #6 #7738

merged 3 commits into from
Jun 20, 2024

Conversation

ByScripts
Copy link
Contributor

@ByScripts ByScripts commented Jun 10, 2024 •
edited
Loading

Description

Enforces import order via the import/order ESLint rule

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@ByScripts ByScripts requested a review from OlivierFL June 10, 2024 14:49
@ByScripts ByScripts self-assigned this Jun 10, 2024
@ByScripts ByScripts force-pushed the eslint-vue-rules-5 branch from 851e43c to a58cfec Compare June 17, 2024 14:50
Base automatically changed from eslint-vue-rules-5 to master June 17, 2024 14:56
@ByScripts ByScripts force-pushed the eslint-vue-rules-6-order-import branch from 723d385 to 3dd55b3 Compare June 17, 2024 14:58
@ByScripts ByScripts marked this pull request as ready for review June 17, 2024 15:00
@ByScripts
Copy link
Contributor Author

@pdonias @MathieuRA Can you merge? Thanks.

@ByScripts ByScripts force-pushed the eslint-vue-rules-6-order-import branch from 3dd55b3 to 6bc86ac Compare June 18, 2024 07:45
@ByScripts ByScripts force-pushed the eslint-vue-rules-6-order-import branch from 6bc86ac to dbe2187 Compare June 19, 2024 15:16
@ByScripts ByScripts mentioned this pull request Jun 19, 2024
Merged
@pdonias pdonias merged commit dd8ad3f into master Jun 20, 2024
1 check passed
@pdonias pdonias deleted the eslint-vue-rules-6-order-import branch June 20, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlivierFL OlivierFL OlivierFL approved these changes

Assignees

@ByScripts ByScripts

Labels
XO Lite XO Web Core XO Web 6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ByScripts @OlivierFL @pdonias