Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@xen-orchestra/fs): create local test directory #8128

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −2
Draft

fix(@xen-orchestra/fs): create local test directory #8128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions @xen-orchestra/fs/src/fs.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@

import 'dotenv/config'
import { forOwn, random } from 'lodash'
import { tmpdir } from 'os'

import { getHandler } from '.'

Expand Down Expand Up @@ -34,7 +33,7 @@
reason => reason
)

const handlers = [`file://${tmpdir()}`]
const handlers = [`file://${__dirname}`]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

if (process.env.xo_fs_nfs) handlers.push(process.env.xo_fs_nfs)
if (process.env.xo_fs_smb) handlers.push(process.env.xo_fs_smb)

Expand All @@ -60,7 +59,7 @@
})
after(async () => {
await handler.forget()
handler = undefined

Check warning on line 62 in @xen-orchestra/fs/src/fs.test.js

View workflow job for this annotation

GitHub Actions / CI 

Possible race condition: `handler` might be reassigned based on an outdated value of `handler`
})

beforeEach(async () => {
Expand Down
Loading