feat(xo-server): remember server's pool name and description #8206
Conversation
b-Nollet
force-pushed
the
remember-pool-name
branch
from
d233b11 to
b05365a
Compare
| if (nameLabel !== undefined || nameDescription !== undefined) { | ||
| const serverId = this.getXenServerIdByObject(pool.uuid, 'pool') | ||
| await this.updateXenServer(serverId, { poolNameDescription: nameDescription, poolNameLabel: nameLabel }) | ||
| } |
There was a problem hiding this comment.
A pool's name may be changed by another client. Also, I think the most common use case for this feature would be to get the name of the pool as soon as the user connects to the server. Updating it when the pool's name_label changes is almost a bonus because it doesn't change that often.
So I think a better approach for this would probably be a sort of hook on the XAPI events to catch any changes of the pools' names and update their servers accordingly.
There was a problem hiding this comment.
What I did does display the name of the pool when a server is added or connected to.
But you're right, I did not realize the pool's name could be changed by another client.
There was a problem hiding this comment.
Yes, you need to watch objects and update the record if there was a change.
A good place for this coold be:
Description
Remember server's pool name and description, and display the pool name as server default label.
XO-437
Checklist
Fixes #007,See xoa-support#42,See https://...)Introduced byCHANGELOG.unreleased.mdReview process
Notes: