-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VM Description in backup report #8253
base: master
Are you sure you want to change the base?
Conversation
Add VM Description in report
Add VM Description in report
Add VM Description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all, thank you for your contribution.
I added a few suggestions to improve what you've done:
- I framed the description of the VM with a {{#if}}{{/if}} to display it only when the VM has a description
- I slightly changed the description display to make it more consistent with the rest of the backup report
- I've modified the changelog message to bring it into line with our habits
There are still two changes that the github interface doesn't allow me to suggest:
- a line
- xo-server-backup-reports minor
should be added to the ‘Packages to release’ section of the changelog (just after- @xen-orchestra/web-core minor
) - the description should be moved from line 9 to line 4 in the markdown template.
If you make these changes, then we can merge your PR as soon as possible.
@@ -13,6 +13,7 @@ | |||
- [Console]: Displays a loader when the console is loading (PR [#8226](https://github.com/vatesfr/xen-orchestra/pull/8226)) | |||
|
|||
> Users must be able to say: “Nice enhancement, I'm eager to test it” | |||
Add VM Description to the backup report. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add VM Description to the backup report. | |
- [Plugin/backup-reports] Add VM Description to the backup report. (contribution made by [@truongtx8](https://github.com/truongtx8)) (PR [#8253](https://github.com/vatesfr/xen-orchestra/pull/8253)) |
<ul> | ||
<li><span style="font-weight: bold">Description</span>: {{vm.name_description}}</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<ul> | |
<li><span style="font-weight: bold">Description</span>: {{vm.name_description}}</li> | |
{{#if vm.name_description}} | |
{{vm.name_description}} | |
{{/if}} | |
<ul> |
@@ -6,6 +6,7 @@ | |||
{{else}} | |||
### VM not found | |||
|
|||
- **Description**: {{{vm.name_description}}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- **Description**: {{{vm.name_description}}} | |
{{#if vm.name_description}} | |
{{{vm.name_description}}} | |
{{/if}} |
This line should also be moved on line 4 (currently it is in the "VM not found" case)
Description
Sometime, the name does not provide enough information about the VM, adding more with Description, we will know more which VM has issue with backup.
Checklist
Fixes #007
,See xoa-support#42
,See https://...
)Introduced by
CHANGELOG.unreleased.md
Review process
Notes: