Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check required packages when -d is specified to make DAG #1070

Closed
gaow opened this issue Sep 29, 2018 · 5 comments
Closed

Check required packages when -d is specified to make DAG #1070

gaow opened this issue Sep 29, 2018 · 5 comments

Comments

@gaow
Copy link
Member

gaow commented Sep 29, 2018

Currently without the following packages the -d will result in failure at the end of SoS execution,

conda install graphviz python-graphviz pillow imageio

It would be good to check for these 3 packages beforehand when -d is specified.

@BoPeng
Copy link
Contributor

BoPeng commented Sep 29, 2018

These things are tricky as the underlying libraries of graphviz and pillow might fail even if these packages are installed. Since this is arguably a less used feature (at least not required for the execution of workflows), I have set them as optional not required...

Also, these packages are not needed for the generation of DAG, but for the preview of DAG, so it does not make sense to check them unless -p is also specified because -p will render the .dot file to animation using these packages.

@gaow
Copy link
Member Author

gaow commented Sep 29, 2018

Oh indeed I meant to say that when -p is used it would be good to check this packages in advance.

@BoPeng
Copy link
Contributor

BoPeng commented Sep 29, 2018

Currently zmq is used to replace pipe (two way paired communication). The problem you report was caused by incorrect response of available process (slots) for the execution of concurrent substeps. It could be fixed but I am looking at more "zmq" way of handling such things, which will take a while...

@gaow
Copy link
Member Author

gaow commented Sep 29, 2018

^(wrong thread?)

@BoPeng
Copy link
Contributor

BoPeng commented Sep 29, 2018

Oh, should be #1056, but maybe I will just fix the concurrent issue in the old way and use a new branch for more advanced usage of zmq.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants