Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency Convergence #5

Closed
danieldietrich opened this issue Sep 21, 2015 · 1 comment
Closed

Dependency Convergence #5

danieldietrich opened this issue Sep 21, 2015 · 1 comment

Comments

@danieldietrich
Copy link
Contributor

Currently we have an issue with the version convergence of the asciidoctorj dependency and the transitive asciidoctorj dependency of the asciidoctorj-pdf plugin.

We should explicitly include the need dependencies in our pom and not rely on any transitive dependency. Especially we should directly include asciidoctorj. But we should not include any SNAPSHOT version of a 3rd party library.

We need a maven build mechanism, which fails the build if there are any conflicting transitive dependencies. This can be accomplished for example with the maven-enforcer-plugin (see also this). Here is an example:

<plugin>
  <groupId>org.apache.maven.plugins</groupId>
  <artifactId>maven-enforcer-plugin</artifactId>
  <version>1.3.1</version>
  <executions>
    <execution>
      <id>enforce</id>
      <configuration>
        <rules>
          <DependencyConvergence/>
        </rules>
      </configuration>
      <goals>
        <goal>enforce</goal>
      </goals>
    </execution>
  </executions>
</plugin>

Is there a better way to do it than with the maven-enforcer-plugin?

Note: We shouldn't shade any dependencies.

@pivovarit
Copy link
Member

no-longer applicable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants