Iterator.takeWhile() #487

vavr-io · Aug 25, 2015 · c6116b4 · c6116b4
1 parent c3c3e25
commit c6116b4
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 3 deletions.
diff --git a/src/main/java/javaslang/collection/HashSet.java b/src/main/java/javaslang/collection/HashSet.java
@@ -446,8 +446,8 @@ public HashSet<T> takeRight(int n) {
     @Override
     public HashSet<T> takeWhile(Predicate<? super T> predicate) {
         Objects.requireNonNull(predicate, "predicate is null");
-        List<T> taken = list.get().takeWhile(predicate);
-        return taken.length() == list.get().length() ? this : HashSet.ofAll(taken);
+        HashSet<T> taken = HashSet.ofAll(iterator().takeWhile(predicate));
+        return taken.length() == length() ? this : taken;
     }
 
     @Override

diff --git a/src/main/java/javaslang/collection/Iterator.java b/src/main/java/javaslang/collection/Iterator.java
@@ -727,7 +727,35 @@ default Iterator<T> takeRight(int n) {
     @Override
     default Iterator<T> takeWhile(Predicate<? super T> predicate) {
         Objects.requireNonNull(predicate, "predicate is null");
-        return null;
+        final Iterator<T> that = this;
+        return new Iterator<T>() {
+
+            private T next = null;
+            private boolean finished = false;
+
+            @Override
+            public boolean hasNext() {
+                while (!finished && next == null && that.hasNext()) {
+                    final T value = that.next();
+                    if (predicate.test(value)) {
+                        next = value;
+                    } else {
+                        finished = true;
+                    }
+                }
+                return next != null;
+            }
+
+            @Override
+            public T next() {
+                if (!hasNext()) {
+                    EMPTY.next();
+                }
+                final T result = next;
+                next = null;
+                return result;
+            }
+        };
     }
 
     default <U> Iterator<Tuple2<T, U>> zip(Iterable<U> that) {