TreeMap.narrow() is not public

[danieldietrich]

Are there other static methods in impl classes that are package private but should be public?

[l0rinc]

We could move the tests to a separate package to see these problems.

I tried, but HashArrayMappedTrie, RedBlackTree, Comparator is not public and used in tests.

Also, the following methods are not public:

• CharSeq.unfold*, CharSer.(CharFunction|CharUnaryOperator)
• Lazy.narrow
• PriorityQueue.(collector|tabulate|fill)
• Array.unfold*
• Vector.unfold*
• CharSeq.indexOfOption
• Queue.unfold*
• LinkedHashSet#ofAll(java.util.stream.Stream<? extends T>)
• Try.NonFatalException#of

and shouldMatchCustomTypeWithUnapplyMethod and a few more from APITest aren't working.

I will commit the production code changes, without moving all the tests (let's do that when no PRs are pending).

[danieldietrich]

@paplorinc Thank you for providing the list of non-public methods!

I will commit the production code changes, without moving all the tests (let's do that when no PRs are pending).

Please let's keep the tests in the current packages. This is junit best practice and saves us from headaches when performing package-private test scenarios. We will keep an eye on the static methods in our code-reviews. In the worst case a new method is not visible for the end-user. This can be fixed.

[l0rinc]

when performing package-private test scenarios

We don't have many of those (nor should we do that often).

[danieldietrich]

@paplorinc Ok, I'm open minded to the idea of moving the test classes. Let's put the tests for classes a.b.c/* in a package a.b.c/test/.