Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iterator should internally not make use of toStream() anymore #1945

Open
8 tasks
danieldietrich opened this issue Apr 12, 2017 · 3 comments
Open
8 tasks

Iterator should internally not make use of toStream() anymore #1945

danieldietrich opened this issue Apr 12, 2017 · 3 comments
Labels
design/refactoring/improvement «vavr-collection»
Milestone
v2.0.0

Comments

@danieldietrich
Copy link
Contributor

danieldietrich commented Apr 12, 2017 •
edited
Loading

Instead we should implement stateful Iterators that achieve the same functionality. The reason is memory-efficiency.

  • foldRight(Object, BiFunction)
  • partition(Predicate)
  • reduceRight(BiFunction)
  • slideBy(Function)
  • span(Predicate)
  • unfoldLeft(Object, Function)
  • unzip(Function)
  • unzip3(Function)
@danieldietrich danieldietrich added this to the 3.0.0 milestone Apr 12, 2017
@ruslansennov ruslansennov mentioned this issue Jun 24, 2017
Merged
@danieldietrich
Copy link
Contributor Author

Closing the issue, Iterator now does not contain toStream() anymore. Thx @ruslansennov for fixing it!

@danieldietrich
Copy link
Contributor Author

Will re-open it, also Stream.ofAll(...) should not be used anymore by Iterator internally.

@ruslansennov ruslansennov mentioned this issue Jun 30, 2017
Merged
@danieldietrich danieldietrich mentioned this issue Sep 6, 2017
Merged
@danieldietrich danieldietrich modified the milestones: vavr-1.0.0, vavr-1.1.0 Nov 26, 2017
@danieldietrich danieldietrich modified the milestones: vavr-1.1.0, vavr-1.0.0 Oct 3, 2018
@danieldietrich
Copy link
Contributor Author

Note: Iterator does not extends Traversable anymore. It might be an option not to implement all methods.

@danieldietrich danieldietrich mentioned this issue Jul 5, 2019
Open
@danieldietrich danieldietrich mentioned this issue May 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design/refactoring/improvement «vavr-collection»
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
1 participant
@danieldietrich