Changed and unified all groupBy methods to keep insertion order
#1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .getOrElse(createFromEntries(Iterator.of(entry))); | ||
| return map.put(key, (M) values); | ||
| }); | ||
| return Collections.groupBy(this, classifier, this::createFromEntries); |
There was a problem hiding this comment.
unified all groupBy methods to use the same template
Merged
Current coverage is 97.22%@@ master #1402 diff @@
==========================================
Files 86 86
Lines 10312 10282 -30
Methods 0 0
Messages 0 0
Branches 1824 1823 -1
==========================================
- Hits 10027 9997 -30
Misses 157 157
Partials 128 128
|
|
Great, thank you! The changes look good to me. I think the formatting might change again (whitespace) because we use different formatters. But that is of minor importance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated it from #1398 upon the request of @ruslansennov.
This way the output of the benchmarks will have has the same order as its definition, not random.