optimized random value generators #1700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 97.03% (diff: 100%)@@ master #1700 diff @@
==========================================
Files 89 89
Lines 11264 11268 +4
Methods 0 0
Messages 0 0
Branches 1878 1876 -2
==========================================
+ Hits 10928 10934 +6
+ Misses 196 195 -1
+ Partials 140 139 -1
|
danieldietrich
commented
Nov 22, 2016
| if (n <= k) { | ||
| return freqGen._2; | ||
| } else { | ||
| n = n - k; |
There was a problem hiding this comment.
Ok for me - it is performed on a copy on the stack. Btw - when dealing with immutable objects (like in Javaslang), then nothing evil can happen at all!
danieldietrich
commented
Nov 22, 2016
| @@ -424,3 +413,27 @@ | |||
| return f.apply(this); | |||
| } | |||
| } | |||
|
|
|||
| final class GenModule { | |||
There was a problem hiding this comment.
Will fix that
sputnikci
reviewed
Nov 22, 2016
| if (n <= k) { | ||
| return freqGen._2; | ||
| } else { | ||
| n = n - k; |
There was a problem hiding this comment.
[Checkstyle] ERROR: Assignment of parameter 'n' is not allowed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INFO: This PR contains a backward compatible API change:
interface Gen<T> { - static Gen<Character> choose(char[] characters) { + static Gen<Character> choose(char... characters) { }