Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make interfaces Serializable #1892

Merged
merged 2 commits into from
Mar 5, 2017
Merged

Make interfaces Serializable #1892

merged 2 commits into from
Mar 5, 2017

Conversation

danieldietrich
Copy link
Contributor

Fixes #1810

@danieldietrich danieldietrich added this to the 2.1.0 milestone Mar 5, 2017
@@ -981,14 +981,14 @@ private boolean isSerializable() {
instanceOf(Either.LeftProjection.class),
instanceOf(Either.RightProjection.class),
instanceOf(Future.class),
instanceOf(Iterator.class),
instanceOf(Validation.class)
instanceOf(Iterator.class)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches before instanceOf(Traversable.class) is checked, so it is ok.

), false),
Case(anyOf(
instanceOf(Either.class),
instanceOf(Option.class),
instanceOf(Try.class),
instanceOf(Traversable.class)
instanceOf(Traversable.class),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In 3.0.0 Iterator will not implement Traversable any more (i.e. all internal ofAll(iterator) calls will be substituted with ofAll(() -> iterator)). So all Traversables will be Serializable.

@codecov-io
Copy link

Codecov Report

Merging #1892 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #1892      +/-   ##
============================================
+ Coverage     98.07%   98.09%   +0.01%     
- Complexity     5051     5052       +1     
============================================
  Files            88       88              
  Lines         11401    11401              
  Branches       1503     1503              
============================================
+ Hits          11182    11184       +2     
+ Misses          113      112       -1     
+ Partials        106      105       -1
Impacted Files Coverage Δ Complexity Δ
...aslang/src/main/java/javaslang/collection/Seq.java 95% <ø> (ø) 50 <0> (ø)
...rc/main/java/javaslang/collection/Traversable.java 96.53% <ø> (ø) 103 <0> (ø)
...aslang/src/main/java/javaslang/control/Option.java 100% <ø> (ø) 42 <0> (ø)
...g/src/main/java/javaslang/collection/Multimap.java 96.61% <ø> (ø) 26 <0> (ø)
...aslang/src/main/java/javaslang/collection/Map.java 97.91% <ø> (ø) 32 <0> (ø)
...slang/src/main/java/javaslang/collection/Tree.java 97.78% <ø> (ø) 113 <0> (ø)
...aslang/src/main/java/javaslang/control/Either.java 100% <ø> (ø) 38 <0> (ø)
...aslang/src/main/java/javaslang/collection/Set.java 75% <ø> (ø) 3 <0> (ø)
javaslang/src/main/java/javaslang/control/Try.java 94.14% <ø> (ø) 76 <0> (ø)
...ng/src/main/java/javaslang/control/Validation.java 99.04% <100%> (ø) 54 <0> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9524ffc...26b9322. Read the comment docs.

@danieldietrich danieldietrich merged commit a9c9ded into vavr-io:master Mar 5, 2017
@danieldietrich danieldietrich deleted the serializable branch March 5, 2017 23:25
@danieldietrich danieldietrich modified the milestones: 2.0.6, 2.1.0 Mar 15, 2017
danieldietrich added a commit that referenced this pull request Apr 3, 2017
@danieldietrich danieldietrich changed the title Serializable Make interfaces Serializable Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants