-
-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make interfaces Serializable #1892
Conversation
@@ -981,14 +981,14 @@ private boolean isSerializable() { | |||
instanceOf(Either.LeftProjection.class), | |||
instanceOf(Either.RightProjection.class), | |||
instanceOf(Future.class), | |||
instanceOf(Iterator.class), | |||
instanceOf(Validation.class) | |||
instanceOf(Iterator.class) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Matches before instanceOf(Traversable.class)
is checked, so it is ok.
), false), | ||
Case(anyOf( | ||
instanceOf(Either.class), | ||
instanceOf(Option.class), | ||
instanceOf(Try.class), | ||
instanceOf(Traversable.class) | ||
instanceOf(Traversable.class), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In 3.0.0 Iterator will not implement Traversable any more (i.e. all internal ofAll(iterator)
calls will be substituted with ofAll(() -> iterator)
). So all Traversables will be Serializable.
Codecov Report
@@ Coverage Diff @@
## master #1892 +/- ##
============================================
+ Coverage 98.07% 98.09% +0.01%
- Complexity 5051 5052 +1
============================================
Files 88 88
Lines 11401 11401
Branches 1503 1503
============================================
+ Hits 11182 11184 +2
+ Misses 113 112 -1
+ Partials 106 105 -1
Continue to review full report at Codecov.
|
Fixes #1810