fix TreeSet.ofAll with comparator and empty values #2255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfekete
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2255 +/- ##
=========================================
Coverage 97.17% 97.17%
Complexity 5344 5344
=========================================
Files 94 94
Lines 12288 12288
Branches 1596 1596
=========================================
Hits 11941 11941
Misses 193 193
Partials 154 154
Continue to review full report at Codecov.
|
|
thank you |
CauchyPeano
pushed a commit
to CauchyPeano/vavr
that referenced
this pull request
Jul 24, 2018
* test for TreeSet.removeAll case that removes all elements from the set * fix TreeSet.ofAll() discarding the comparator when creating empty set * removed unnecessary @SuppressWarnings * test for TreeSet.ofAll with explicit comparator and empty initial values
danieldietrich
pushed a commit
that referenced
this pull request
Jan 6, 2019
* test for TreeSet.removeAll case that removes all elements from the set * fix TreeSet.ofAll() discarding the comparator when creating empty set * removed unnecessary @SuppressWarnings * test for TreeSet.ofAll with explicit comparator and empty initial values
danieldietrich
pushed a commit
that referenced
this pull request
Jan 16, 2019
* test for TreeSet.removeAll case that removes all elements from the set * fix TreeSet.ofAll() discarding the comparator when creating empty set * removed unnecessary @SuppressWarnings * test for TreeSet.ofAll with explicit comparator and empty initial values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2254