Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of last() call on TreeMap #2400

Merged
merged 1 commit into from
Mar 31, 2019

Conversation

craffit
Copy link
Contributor

@craffit craffit commented Mar 29, 2019

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #2400 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2400      +/-   ##
============================================
- Coverage     95.79%   95.79%   -0.01%     
- Complexity     5427     5428       +1     
============================================
  Files            94       94              
  Lines         13110    13113       +3     
  Branches       1608     1608              
============================================
+ Hits          12559    12561       +2     
- Misses          404      405       +1     
  Partials        147      147
Impacted Files Coverage Δ Complexity Δ
vavr/src/main/java/io/vavr/collection/TreeMap.java 94.29% <100%> (+0.06%) 165 <2> (+2) ⬆️
...vr/src/main/java/io/vavr/collection/SortedMap.java 66.66% <0%> (-33.34%) 2% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f34c252...4b3f272. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Mar 29, 2019

Codecov Report

Merging #2400 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2400      +/-   ##
============================================
- Coverage     95.79%   95.79%   -0.01%     
- Complexity     5427     5428       +1     
============================================
  Files            94       94              
  Lines         13110    13113       +3     
  Branches       1608     1608              
============================================
+ Hits          12559    12561       +2     
- Misses          404      405       +1     
  Partials        147      147
Impacted Files Coverage Δ Complexity Δ
vavr/src/main/java/io/vavr/collection/TreeMap.java 94.29% <100%> (+0.06%) 165 <2> (+2) ⬆️
...vr/src/main/java/io/vavr/collection/SortedMap.java 66.66% <0%> (-33.34%) 2% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f34c252...4b3f272. Read the comment docs.

@danieldietrich
Copy link
Contributor

Awesome, thank you - I think we missed that one :)

@danieldietrich danieldietrich merged commit ebac4c1 into vavr-io:master Mar 31, 2019
@danieldietrich danieldietrich added this to the v0.10.1 milestone Mar 31, 2019
@danieldietrich danieldietrich modified the milestones: v0.10.1, v0.11.0, v1.0.0 Jul 2, 2019
thadumi pushed a commit to thadumi/vavr that referenced this pull request Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants