Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClassCastException during pattern matching #2403

Merged
merged 1 commit into from
Mar 31, 2019
Merged

Conversation

danieldietrich
Copy link
Contributor

@danieldietrich danieldietrich commented Mar 31, 2019

Fixes #2401

@danieldietrich danieldietrich added this to the v0.10.1 milestone Mar 31, 2019
@danieldietrich
Copy link
Contributor Author

I know that the changes exceed the scope of the original issue a bit. I did an additional small refactoring that was related to the instanceof check within patterns.

@danieldietrich danieldietrich changed the title Fixes issue #2401 ClassCastException during pattern matching Mar 31, 2019
@codecov-io
Copy link

Codecov Report

Merging #2403 into master will increase coverage by 0.06%.
The diff coverage is 95.45%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2403      +/-   ##
============================================
+ Coverage     95.79%   95.85%   +0.06%     
  Complexity     5428     5428              
============================================
  Files            94       94              
  Lines         13113    13117       +4     
  Branches       1608     1609       +1     
============================================
+ Hits          12561    12573      +12     
  Misses          405      405              
+ Partials        147      139       -8
Impacted Files Coverage Δ Complexity Δ
vavr/src-gen/main/java/io/vavr/API.java 84.15% <95.45%> (+0.75%) 222 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8344e95...3163593. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Mar 31, 2019

Codecov Report

Merging #2403 into master will increase coverage by 0.06%.
The diff coverage is 95.45%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2403      +/-   ##
============================================
+ Coverage     95.79%   95.85%   +0.06%     
  Complexity     5428     5428              
============================================
  Files            94       94              
  Lines         13113    13117       +4     
  Branches       1608     1609       +1     
============================================
+ Hits          12561    12573      +12     
  Misses          405      405              
+ Partials        147      139       -8
Impacted Files Coverage Δ Complexity Δ
vavr/src-gen/main/java/io/vavr/API.java 84.15% <95.45%> (+0.75%) 222 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8344e95...3163593. Read the comment docs.

@danieldietrich danieldietrich merged commit 71f55e0 into master Mar 31, 2019
@danieldietrich danieldietrich deleted the issue-2401 branch March 31, 2019 21:07
@danieldietrich danieldietrich modified the milestones: v0.10.1, v0.11.0, v1.0.0 Jul 2, 2019
danieldietrich added a commit that referenced this pull request Jul 22, 2019
thadumi pushed a commit to thadumi/vavr that referenced this pull request Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClassCastException during pattern matching
2 participants