Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: Re-adds the automatic module name #2583

Merged
merged 1 commit into from
May 15, 2020

Conversation

danieldietrich
Copy link
Contributor

Second part of #2573

It was removed in fa48892 in disappeared in v0.10.2.

In #2573 we figured out that the previous module names did not collide. This PR restores them.

@danieldietrich danieldietrich added this to the v0.10.3 milestone May 15, 2020
@danieldietrich danieldietrich changed the title Re-adds the automatic module name Backport: Re-adds the automatic module name May 15, 2020
@codecov-io
Copy link

codecov-io commented May 15, 2020

Codecov Report

Merging #2583 into v0.10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              v0.10    #2583   +/-   ##
=========================================
  Coverage     95.81%   95.81%           
  Complexity     5433     5433           
=========================================
  Files            94       94           
  Lines         13139    13139           
  Branches       1621     1621           
=========================================
  Hits          12589    12589           
  Misses          405      405           
  Partials        145      145           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08a7349...9327458. Read the comment docs.

Copy link
Member

@mincong-h mincong-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@danieldietrich danieldietrich merged commit 17f16a6 into v0.10 May 15, 2020
@danieldietrich danieldietrich deleted the automatic-module-name branch May 15, 2020 07:20
@danieldietrich
Copy link
Contributor Author

Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants