Fix issue on meteor 3.0 on patch publish and perserve env variable #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @nachocodoner Thank you for creating this PR. Regarding tests, we recently had problems with running tests both on the CI and locally. We are currently working on fixing it. As for the PR, I've tested this manually and it seems to solve the issue just fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refers to the issue #190 and refered to the core at meteor/meteor#13258.
The fix involves using
EnvironmentVariable.withValuebefore callingpublish.call. This ensures the context is preserved and spread properly throughout the entire flow of an altered publication. This was a breaking change on Meteor 3 added on this change, meteor/meteor#13063.I tried running the test suite to check if anything else is broken that might need deeper investigation on the meteor core level or if this fix is sufficient for all publication alterations as the one on this repository. I also wanted to add a regression test, but the suite isn't passing any tests. What am I doing wrong?