Added filtering undefined values in array of SelectField (fixes #691).

vazco · Mar 25, 2020 · 71f8e87 · 71f8e87
1 parent 381541f
commit 71f8e87
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 1 deletion.
diff --git a/packages/uniforms-antd/__tests__/SelectField.tsx b/packages/uniforms-antd/__tests__/SelectField.tsx
@@ -177,6 +177,21 @@ test('<SelectField> - renders a select which correctly reacts on change (array)'
   expect(onChange).toHaveBeenLastCalledWith('x', ['b']);
 });
 
+test('<SelectField> - renders a select (undefined values)', () => {
+  const element = <SelectField name="x" value={[undefined, 'a', undefined]} />;
+  const wrapper = mount(
+    element,
+    createContext({
+      x: { type: Array },
+      'x.$': { type: String, allowedValues: ['a', 'b'] },
+    }),
+  );
+
+  expect(wrapper.find(Select)).toHaveLength(1);
+  expect(wrapper.find(Select).prop('value')).not.toContain(undefined);
+  expect(wrapper.find(Select).prop('value')).toContain('a');
+});
+
 test('<SelectField> - renders a select which correctly reacts on change (empty)', () => {
   const onChange = jest.fn();
 

diff --git a/packages/uniforms-antd/src/SelectField.tsx b/packages/uniforms-antd/src/SelectField.tsx
@@ -39,7 +39,13 @@ const renderSelect = props => (
     onChange={value => props.onChange(value)}
     placeholder={props.placeholder}
     ref={props.inputRef}
-    value={props.value || (props.fieldType === Array ? [] : undefined)}
+    value={
+      props.fieldType === Array
+        ? props.value
+          ? props.value.filter(value => value !== undefined)
+          : []
+        : props.value
+    }
     {...filterDOMProps(props)}
   >
     {props.allowedValues.map(value => (