Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SimpleSchema2Bridge with simpl-schema package #107

Merged
merged 2 commits into from
Sep 28, 2016

Conversation

logankoester
Copy link
Contributor

Some fixes required to get the new SimpleSchema2 bridge working after updating to v1.1.1

Copy link
Contributor

@radekmie radekmie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, remove this dependency and I will publish this ASAP.

@@ -31,8 +31,7 @@ try {
);
} catch (_) { /* Ignore it. */ }

// export default class SimpleSchema2Bridge extends Bridge {
export class SimpleSchema2Bridge extends Bridge {
export default class SimpleSchema2Bridge extends Bridge {
Copy link
Contributor

@radekmie radekmie Sep 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's a terrible typo.

(publish before going to bed is generally a bad idea)

@radekmie radekmie merged commit 1160b38 into vazco:master Sep 28, 2016
@radekmie radekmie added the Type: Bug Bug reports and their fixes label Sep 28, 2016
@radekmie
Copy link
Contributor

I've merged it, changed simpl-schema to a peer dependency and released 1.1.2.

Thank you, @logankoester!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Bug reports and their fixes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants