Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SimpleSchema2Bridge with simpl-schema package #107

Merged
merged 2 commits into from
Sep 28, 2016
Merged

Enable SimpleSchema2Bridge with simpl-schema package #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
444cf63
Adds npm dependency 'simpl-schema'
logankoester Sep 28, 2016
39e9e1b
Bridges must export default class from implementation
logankoester Sep 28, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/uniforms/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@
"lodash.get": "^4.4.2",
"lodash.isequal": "^4.4.0",
"lodash.set": "^4.3.2",
"lodash.xorwith": "^4.5.0"
"lodash.xorwith": "^4.5.0",
"simpl-schema": "0.0.3"
}
}
3 changes: 1 addition & 2 deletions packages/uniforms/src/bridges/SimpleSchema2Bridge.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@ try {
);
} catch (_) { /* Ignore it. */ }

// export default class SimpleSchema2Bridge extends Bridge {
export class SimpleSchema2Bridge extends Bridge {
export default class SimpleSchema2Bridge extends Bridge {
Copy link
Contributor

@radekmie radekmie Sep 28, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's a terrible typo.

(publish before going to bed is generally a bad idea)

static check (schema) {
return SimpleSchema && (
schema &&
Expand Down