Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Material UI v1 #349

Closed
cvburgess opened this issue Sep 28, 2017 · 23 comments
Closed

Support for Material UI v1 #349

cvburgess opened this issue Sep 28, 2017 · 23 comments
Assignees
Labels
Type: Feature New features and feature requests

Comments

@cvburgess
Copy link

When using Uniforms-Material with a Material-UI v1 project I get the following error.

Module not found: Can't resolve 'material-ui/RaisedButton' in '.../node_modules/uniforms-material'

Is there any plan to support Material UI v1?

@radekmie radekmie self-assigned this Sep 28, 2017
@radekmie radekmie added the Type: Feature New features and feature requests label Sep 28, 2017
@radekmie
Copy link
Contributor

Is it released already? It's still in beta I think. Right now I'm quite focused on React@16, but yes, it is a plan to support it. Maybe @janowsiany will say something more.

@janowsiany
Copy link
Contributor

janowsiany commented Sep 28, 2017

Yes i am planning to submit this as part of Hacktoberfest so stay tuned. Also if you have something done already then i would love to see that so we could work it out together. Another question which comes to my mind is what about backward compatibility? I mean migration to material-ui@1.x.x is definately a breaking change for uniforms-material package.

@janowsiany janowsiany self-assigned this Sep 28, 2017
@cvburgess
Copy link
Author

If you need help, please let me know - happy to contribute.

@cvburgess
Copy link
Author

Any progress on this or ways I can help? My team would really like to see this implemented for a project we are building out. I could open a PR with an initial stab at it if that helps.

@janowsiany
Copy link
Contributor

janowsiany commented Oct 12, 2017

@cvburgess i have an unexpected slippage but i would expect a PR for this at the beginning of the next week.

@janowsiany
Copy link
Contributor

janowsiany commented Oct 15, 2017

@cvburgess you can check progress #355, perfectly if you also give a feedback.
Most components are ported already. Some layout issues still need to be fixed.
If you want to run demo, then you need to:

  • remove muiTheme from Application.childContextTypes and Application.getChildContext
  • drop react-tap-event-plugin dependency

@cvburgess
Copy link
Author

@janowsiany I'm running into this issue npm/npm#2974 because uniforms uses Lerna. Any idea how i can install your WIP branch?

@janowsiany
Copy link
Contributor

@cvburgess Sorry for the delay. I beleive that the easiest way would be to clone my fork of uniforms, then checkout material-ui-next branch and then in the top directory run npm install this way you would be able to install uniforms-material as a local package. Check how it is done in demo app.

@cvburgess
Copy link
Author

@janowsiany I was able to install it locally but I got tons and tons of errors once it got to webpack. When is this supposed to go live?

@radekmie
Copy link
Contributor

radekmie commented Nov 1, 2017

@cvburgess Definitely not sooner than 1.0.0 release.

@ipchikin
Copy link

ipchikin commented Nov 3, 2017

@radekmie Is that possible to install it like npm i -S uniforms-material@next?

@radekmie
Copy link
Contributor

radekmie commented Nov 3, 2017

@ipchikin no, we do not do pre-releases. However, there surely will be an alpha/beta/rc version.

@cvburgess
Copy link
Author

@janowsiany - getting some errors with type: Number inputs when changing the value:

NumField.js:107 Uncaught TypeError: Cannot read property 'value' of undefined
    at Num.onChange (NumField.js:107)
    at Object.onChange (NumField.js:68)
    at Input._this.handleChange (Input.js:461)
    at Object.executeOnChange (LinkedValueUtils.js:130)
    at ReactDOMComponent._handleChange (ReactDOMInput.js:239)
    at HTMLUnknownElement.boundFunc (ReactErrorUtils.js:63)
    at Object.ReactErrorUtils.invokeGuardedCallback (ReactErrorUtils.js:69)
    at executeDispatch (EventPluginUtils.js:83)
    at Object.executeDispatchesInOrder (EventPluginUtils.js:106)
    at executeDispatchesAndRelease (EventPluginHub.js:41)

Great work on the update so far!

@cvburgess
Copy link
Author

Also, when passing options via SimpleSchema2 the following React error occurs:

warning.js:33 Warning: Unknown prop `options` on <div> tag. Remove this prop from the element. For details, see https://fb.me/react-unknown-prop
    in div (created by FormControl)
    in FormControl (created by withStyles(FormControl))
    in withStyles(FormControl) (created by TextField)
    in TextField (created by Select_)
    in div (created by Grid)
    in Grid (created by GridWrapper)
    in GridWrapper (created by withStyles(GridWrapper))
    in withStyles(GridWrapper) (created by Select_)
    in Select_ (created by Select_Field)
    in Select_Field (created by AutoField)
    in AutoField (created by AutoValidatedQuickMaterialForm)
    in form (created by AutoValidatedQuickMaterialForm)
    in AutoValidatedQuickMaterialForm (created by SlaDetail)
    in div (created by Paper)
    in Paper (created by withStyles(Paper))
    in withStyles(Paper) (created by SlaDetail)
    in div (created by Grid)
    in Grid (created by GridWrapper)
    in GridWrapper (created by withStyles(GridWrapper))
    in withStyles(GridWrapper) (created by SlaDetail)
    in div (created by Grid)
    in Grid (created by GridWrapper)
    in GridWrapper (created by withStyles(GridWrapper))
    in withStyles(GridWrapper) (created by SlaDetail)
    in div (created by SlaDetail)
    in SlaDetail (created by _class)
    in _class (created by withStyles(_class))
    in withStyles(_class) (created by RouterContext)
    in div (created by Main)
    in Main (created by BranchedMain)
    in BranchedMain (created by RouterContext)
    in div (created by UserDataPreloader)
    in UserDataPreloader (created by _class)
    in _class (created by RouterContext)
    in div (created by App)
    in div (created by App)
    in App (created by _class)
    in _class (created by withStyles(_class))
    in withStyles(_class) (created by RootedStyle)
    in RootedStyle (created by RouterContext)
    in RouterContext (created by Router)
    in Router
    in MuiThemeProvider (created by MuiThemeProviderWrapper)
    in MuiThemeProviderWrapper

@TimoRuetten
Copy link

Hm its sad that you don't prerelease it. We are currently using 1.0 of material ui in our project. Sadly its not possible to use uniform yet. It would be nice if you would provide a doc how to add custom themes. With this everyone could build own themes easily.

@radekmie
Copy link
Contributor

@TimoRuetten: a custom theme is simply a set of your fields. Simply copy one of the default ones and fill your own components.

@TimoRuetten
Copy link

Hm. You're right. I was thinking of AutoForm from meteor which had its own API for own themes as far as I remember. I will check it out and will check if its faster for us to do it this way. Thanks :)

@radekmie
Copy link
Contributor

Theres no need for such API as you’ll use components directly or through <AutoField />.

@ipchikin
Copy link

@radekmie Is there an alpha/beta/rc version now?

@radekmie
Copy link
Contributor

No, material-ui is still in beta.

@mattblackdev
Copy link

ahhhh this is so exciting!! :)

@titeya
Copy link

titeya commented May 15, 2018

For testing with the v1.0.0-rc.0 release :
https://www.npmjs.com/package/uniforms--material-ui

@raedle
Copy link

raedle commented May 15, 2018

@titeya Thanks for sharing. I added a PR to fix issue with arrays/lists in AutoForm

@radekmie radekmie moved this to Closed in Open Source Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New features and feature requests
Projects
Archived in project
Development

No branches or pull requests

8 participants