Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Support material-ui v1 #355

Closed
wants to merge 14 commits into from
Closed

[WIP] Support material-ui v1 #355

wants to merge 14 commits into from

Conversation

janowsiany
Copy link
Contributor

@janowsiany janowsiany commented Oct 15, 2017

#349
Things which still need to be done:

  • layout
  • tests
  • ?icons

@janowsiany janowsiany added the Type: Feature New features and feature requests label Oct 15, 2017
@janowsiany janowsiany self-assigned this Oct 15, 2017
@janowsiany janowsiany requested a review from radekmie as a code owner October 15, 2017 17:32
@radekmie
Copy link
Contributor

We've decided internally, that this will be released along with material-ui@1 and uniforms-material will be kept up to date with the newest release.

@tomscholz
Copy link

@janowsiany When using with material-ui@1.0.0-beta.21 I get the following error:

Uncaught Error: Cannot find module 'material-ui/Toggle'
    at makeMissingError (modules-runtime.js?hash=8587d188e038b75ecd27ed2469a52b269e38fb62:231)
    at require (modules-runtime.js?hash=8587d188e038b75ecd27ed2469a52b269e38fb62:241)
    at BoolField.js (modules.js?hash=88f8f10435408c0f364ee2d499b1b0b3692ec77c:94333)
    at fileEvaluate (modules-runtime.js?hash=8587d188e038b75ecd27ed2469a52b269e38fb62:343)
    at require (modules-runtime.js?hash=8587d188e038b75ecd27ed2469a52b269e38fb62:238)
    at AutoField.js (modules.js?hash=88f8f10435408c0f364ee2d499b1b0b3692ec77c:94073)
    at fileEvaluate (modules-runtime.js?hash=8587d188e038b75ecd27ed2469a52b269e38fb62:343)
    at require (modules-runtime.js?hash=8587d188e038b75ecd27ed2469a52b269e38fb62:238)
    at AutoFields.js (modules.js?hash=88f8f10435408c0f364ee2d499b1b0b3692ec77c:90751)
    at fileEvaluate (modules-runtime.js?hash=8587d188e038b75ecd27ed2469a52b269e38fb62:343)

Any ideas or thoughts how that could be solved?

@janowsiany
Copy link
Contributor Author

Hey, @tomscholz sorry for this delay.
There were 5 material-ui beta realeased since i last checked this PR so perhaps they have made a breaking change. Could you confirm that with 1.0.0-beta.16 it is working?

@mkbctrl
Copy link

mkbctrl commented Apr 30, 2018

@janowsiany Serwus, chciałem spytać o status, są jakieś szanse połączenia w najbliższej przyszłości?
Pewnie trudno wam nadążyć za ich beta branchem :/

Tak się akurat składa, że bardzo by mi się przydała ta część w moim projekcie. Można używać czy lepiej nie?

@janowsiany
Copy link
Contributor Author

Hopefully material-ui@1.0.0 will be released on 17th of May, so you may expect that uniforms will support the newly released version up to two weeks after the release date.

@raedle
Copy link

raedle commented May 14, 2018

The @material-ui/core rc-0 is out. I'm happy to test a pre-release of uniforms/material-ui v1 :)

@janowsiany
Copy link
Contributor Author

Closing in favor of #427

@janowsiany janowsiany closed this May 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New features and feature requests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants