[WIP] Support material-ui 1.0.0 #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov Report
@@ Coverage Diff @@
## master #427 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 157 157
Lines 1401 1404 +3
=====================================
+ Hits 1401 1404 +3
Continue to review full report at Codecov.
|
radekmie
suggested changes
May 24, 2018
There was a problem hiding this comment.
Few things:
- (demo project) If you'll add a new
friendfield item, fill the first one and remove it, then theageis still there. It's not the case in other themes or currentuniforms-material. - There are few more ordering problems, so maybe let's skip them for now and let's add it to the ESLint. What do you think?
- I'm a bit concerned about all the new props being passed to some in-between components, like the
<FormControl />or<List />. It may be a problem to mantain all of them.
| import AlarmIcon from '@material-ui/icons/Alarm'; | ||
| import React from 'react'; | ||
| import {mount} from 'enzyme'; | ||
| import IconButton from '@material-ui/core/IconButton'; |
| import AlarmIcon from '@material-ui/icons/Alarm'; | ||
| import React from 'react'; | ||
| import {mount} from 'enzyme'; | ||
| import IconButton from '@material-ui/core/IconButton'; |
| import {mount} from 'enzyme'; | ||
|
|
||
| import SelectField from 'uniforms-material/SelectField'; | ||
| import Select from '@material-ui/core/Select'; |
| "uniforms": "^1.24.3" | ||
| }, | ||
| "dependencies": { | ||
| "babel-runtime": "^6.20.0", | ||
| "prop-types": "^15.5.7" |
There was a problem hiding this comment.
Are these changes necessary? Also, babel-runtime is not required anymore?
| "react": "^16.0.0 || ^15.0.0 || ^0.14.0", | ||
| "@material-ui/core": "^1.0.0", | ||
| "@material-ui/icons": "1.0.0", | ||
| "react": "^16.3.0", |
There was a problem hiding this comment.
Is this a @material-ui/core requirement?
| import joinName from 'uniforms/joinName'; | ||
| import List from '@material-ui/core/List'; | ||
| import ListSubheader from '@material-ui/core/ListSubheader'; | ||
| import React from 'react'; |
| )} | ||
| </List> | ||
| <ListAddField name={`${name}.$`} initialCount={initialCount} /> | ||
| </Fragment> |
There was a problem hiding this comment.
If @material-ui/core doesn't require react@16, I'd rather go with the <div /> and have more compatibility.
| allowedValues, | ||
| checkboxes, // eslint-disable-line no-unused-vars |
|
|
||
| const Radio = ({ | ||
| const Radio_ = ({ |
There was a problem hiding this comment.
If so, use the displayName to let the field be called RadioField.
|
|
||
| import ListAddField from './ListAddField'; | ||
| import ListItemField from './ListItemField'; | ||
|
|
||
| const List = ({ | ||
| actionsStyle, | ||
| const List_ = ({ |
There was a problem hiding this comment.
If so, use the displayName to let the field be called ListField.
…icons, ensureValue: true for fields
…ames, changes for dependencies
radekmie
approved these changes
Jun 5, 2018
|
So, we have it! I'll do a pre-release soon. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is follow up of #355
I still want to add support for
helperTextproperty.Tests need too be fixed.