Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of globalThis #641

Closed
Floriferous opened this issue Nov 11, 2019 · 1 comment
Closed

Remove use of globalThis #641

Floriferous opened this issue Nov 11, 2019 · 1 comment
Assignees
Labels
Type: Feature New features and feature requests

Comments

@Floriferous
Copy link
Contributor

Related to #619.

The use of globalThis in the recent versions of uniforms-material has caused a bit of pain in our codebase including our testing setup.

I see that this is only used in one small place in DateField. From what I understand about it (never seen it before), it requires a polyfill to work outside of typescript (which you also use for your documentation website).

For this one single line in this repo, we have to import and use a polyfill, so is it really necessary?

@refactorized
Copy link

Had this issue too, and in my case just replaced globalThis with window. Not sure if that helps, but +1 on this issue from me.

@kestarumper kestarumper self-assigned this Nov 13, 2019
@kestarumper kestarumper added the Type: Question Questions and other discussions label Nov 13, 2019
@radekmie radekmie added Type: Feature New features and feature requests and removed Type: Question Questions and other discussions labels Nov 13, 2019
@radekmie radekmie moved this to Closed in Open Source Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New features and feature requests
Projects
Archived in project
Development

No branches or pull requests

4 participants