Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove globalThis (fixes #641). #645

Merged
merged 1 commit into from
Nov 13, 2019
Merged

Remove globalThis (fixes #641). #645

merged 1 commit into from
Nov 13, 2019

Conversation

kestarumper
Copy link
Member

In #619 we added globalThis but it appears not to be widely supported nor automatically polyfilled.

Related issue: #641

@kestarumper kestarumper added the Type: Feature New features and feature requests label Nov 13, 2019
@kestarumper kestarumper requested a review from radekmie November 13, 2019 15:34
@codecov
Copy link

codecov bot commented Nov 13, 2019

Codecov Report

Merging #645 into master will decrease coverage by 0.28%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #645      +/-   ##
==========================================
- Coverage    99.6%   99.32%   -0.29%     
==========================================
  Files         163      163              
  Lines        1782     1782              
  Branches      547      552       +5     
==========================================
- Hits         1775     1770       -5     
  Misses          1        1              
- Partials        6       11       +5
Impacted Files Coverage Δ
packages/uniforms-semantic/src/DateField.tsx 93.75% <0%> (-6.25%) ⬇️
packages/uniforms-material/src/DateField.tsx 92.3% <0%> (-7.7%) ⬇️
packages/uniforms-unstyled/src/DateField.tsx 91.66% <0%> (-8.34%) ⬇️
packages/uniforms-bootstrap3/src/DateField.tsx 90.9% <0%> (-9.1%) ⬇️
packages/uniforms-bootstrap4/src/DateField.tsx 90.9% <0%> (-9.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7904e7f...6c0a2c6. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New features and feature requests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants