Fixed changed state of AutoForm #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v3 #765 +/- ##
==========================================
- Coverage 97.82% 97.79% -0.03%
==========================================
Files 175 175
Lines 3398 3398
Branches 641 641
==========================================
- Hits 3324 3323 -1
Misses 8 8
- Partials 66 67 +1
Continue to review full report at Codecov.
|
Monteth
approved these changes
Jul 13, 2020
kestarumper
approved these changes
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should fix the regression introduced in #739. Due to the removal of
modelSync,AutoFormwas no longer resolvingchangedandchangedMapcorrectly, effectively not trackingchangedstates at all. I've fixed that, added test for that,and fixed other tests, as they were using shared form instance(I've moved that directly to v3 branch).Once more, thanks to @mvgijssel for #739 (comment)!