Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed AutoForm validation (fixes #769). #771

Merged
merged 1 commit into from
Jul 29, 2020
Merged

Conversation

radekmie
Copy link
Contributor

The fix made in #765 broke the validation of AutoForm, as reported in #769. This change fixes that, by removing an obsolete onValidate override in AutoForm.

@radekmie radekmie added the Type: Bug Bug reports and their fixes label Jul 23, 2020
@radekmie radekmie added this to the v3.0 milestone Jul 23, 2020
@radekmie radekmie requested review from kestarumper and Monteth July 23, 2020 10:01
@codecov
Copy link

codecov bot commented Jul 23, 2020

Codecov Report

Merging #771 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #771      +/-   ##
==========================================
- Coverage   97.64%   97.64%   -0.01%     
==========================================
  Files         175      175              
  Lines        3402     3400       -2     
  Branches      642      642              
==========================================
- Hits         3322     3320       -2     
  Misses          8        8              
  Partials       72       72              
Impacted Files Coverage Δ
packages/uniforms/src/AutoForm.tsx 96.87% <ø> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc36034...76bcbb7. Read the comment docs.

@radekmie radekmie merged commit eb99b73 into master Jul 29, 2020
@radekmie radekmie deleted the fix-autoform-validation branch July 29, 2020 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Bug reports and their fixes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants