Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClassName for SelectField #785

Closed
michael-vasyliv opened this issue Aug 12, 2020 · 5 comments · Fixed by #795
Closed

ClassName for SelectField #785

michael-vasyliv opened this issue Aug 12, 2020 · 5 comments · Fixed by #795
Assignees
Labels
Type: Question Questions and other discussions
Milestone

Comments

@michael-vasyliv
Copy link
Contributor

michael-vasyliv commented Aug 12, 2020

It seems like className does not work for SelectField
inside component
Screenshot from 2020-08-12 15-38-24

in HTML
Screenshot from 2020-08-12 15-38-04

additional information:
"preact-cli": "3.0.0-rc.7",
"preact": "10.3.4",
"preact-render-to-string": "5.1.4",
"preact-router": "^3.1.0",
"uniforms": "^3.0.0-rc.0",
"uniforms-bootstrap4": "^3.0.0-rc.0",
"uniforms-bridge-json-schema": "^3.0.0-rc.0",

@radekmie radekmie self-assigned this Aug 12, 2020
@radekmie radekmie added the Type: Question Questions and other discussions label Aug 12, 2020
@radekmie
Copy link
Contributor

Hi @michael-vasyliv. I can see that there's an incorrect props type, but besides that - do you think that className is needed? There are others, specialized ones.

@michael-vasyliv
Copy link
Contributor Author

@radekmie there are so many classes and no one fits me, I want to add class beside form-group. As I understand SelectField extends from BaseField that takes className as a prop so in my opinion, it should work but I have a bug.

@michael-vasyliv
Copy link
Contributor Author

@radekmie I took all classes that are discribed in https://uniforms.tools/docs/api-fields#selectfield (all props that have suffix className) and no one adds className beside form-group

@michael-vasyliv
Copy link
Contributor Author

michael-vasyliv commented Aug 12, 2020

@radekmie or are least there is a question is it a bug or its a designed feature (not accept className in SelectField)? because it works fine for TextField, but for SelectField it does not work
Screenshot from 2020-08-12 18-35-07

@radekmie
Copy link
Contributor

@michael-vasyliv That's odd - we'll check that.

@radekmie radekmie assigned Monteth and unassigned radekmie Aug 19, 2020
@radekmie radekmie added this to the v3.0 milestone Apr 22, 2022
@radekmie radekmie linked a pull request Apr 22, 2022 that will close this issue
@radekmie radekmie moved this to Closed in Open Source Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Question Questions and other discussions
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants