Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#785 class name for select field #795

Merged
merged 5 commits into from
Sep 9, 2020
Merged

#785 class name for select field #795

merged 5 commits into from
Sep 9, 2020

Conversation

michael-vasyliv
Copy link
Contributor

@michael-vasyliv michael-vasyliv commented Aug 28, 2020 •
edited
Loading

#785
This PR will fix issue #785 and probably #793, the problem was in a Spread syntax in the SelectField for bootstrap4, before pass props to wrapField few properties were removed from props, that is why in wrapField there were undefined.

@codecov
Copy link

codecov bot commented Aug 28, 2020 •
edited
Loading

Codecov Report

Merging #795 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #795      +/-   ##
==========================================
- Coverage   97.60%   97.60%   -0.01%     
==========================================
  Files         175      175              
  Lines        3425     3422       -3     
  Branches      644      644              
==========================================
- Hits         3343     3340       -3     
  Misses          8        8              
  Partials       74       74
Impacted Files Coverage Δ
packages/uniforms-bootstrap4/src/SelectField.tsx 87.50% <ø> (-0.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0b0f56...650044f. Read the comment docs.

@michael-vasyliv michael-vasyliv mentioned this pull request Sep 2, 2020
Closed
@radekmie radekmie added the Type: Feature New features and feature requests label Sep 2, 2020
radekmie
radekmie approved these changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@radekmie radekmie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, @michael-vasyliv!

@michael-vasyliv
Copy link
Contributor Author

michael-vasyliv commented Sep 9, 2020 •
edited
Loading

@radekmie you are welcome. When will these changes go to a new version?

@radekmie
Copy link
Contributor

radekmie commented Sep 9, 2020

I'm working on it.

@radekmie radekmie merged commit 975d454 into vazco:master Sep 9, 2020
@michael-vasyliv
Copy link
Contributor Author

@radekmie thank you.

@michael-vasyliv michael-vasyliv deleted the #785-class-name-for-select-field branch February 18, 2021 19:06
@radekmie radekmie added this to the v3.0 milestone Apr 22, 2022
This was linked to issues Apr 22, 2022
Select does not show inline error #793
Closed
ClassName for SelectField #785
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radekmie radekmie radekmie approved these changes

Assignees
No one assigned
Labels
Type: Feature New features and feature requests
Projects
Open Source
Archived in project
Milestone
v3.0
Development

Successfully merging this pull request may close these issues.

Select does not show inline error ClassName for SelectField
2 participants
@michael-vasyliv @radekmie