Added showInlineError to bootstrap theme #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If true, we could include the error message as a text block with the input form. This seems like a very useful option, especially for forms where the errors are not rendered.
|
Yes, inline errors are useful. |
| @@ -41,11 +42,13 @@ const FormGroup = ({ | |||
| <section className={classnames(wrapClassName, gridClassName(grid, 'input'))}> | |||
| {children} | |||
| {makeHelp(help, helpClassName)} | |||
| {error && showError ? makeHelp(error, 'text-help') : ''} | |||
There was a problem hiding this comment.
Why makeHelp(error, ...) and not errorMessage?
There was a problem hiding this comment.
It needs to be wrapped in <span.text-help>
There was a problem hiding this comment.
Yes, I get it, but error is an object, not a String - errorMessage is a String.
|
Two more things: how about renaming it to Could you also implement it for bootstrap-3? |
|
Sure - I was just making sure you were on-board... I'll whip it up |
zeroasterisk
changed the title
showError BooleanshowInlineError Boolean
|
@radekmie ok - bootstrap 3 & 4 are implemented, |
|
Great! |
radekmie
changed the title
showInlineError Boolean
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If true, we could include the error message as a text block with the input form.
This seems like a very useful option,
especially for forms where the errors are not rendered.