Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed additional props warning #89

Closed
wants to merge 2 commits into from
Closed

Fixed additional props warning #89

wants to merge 2 commits into from

Conversation

zeroasterisk
Copy link
Contributor

@zeroasterisk zeroasterisk commented Aug 4, 2016 •
edited
Loading

Warning: Unknown prop grid on section tag.
Remove this prop from the element

@zeroasterisk
Removed ...props from SubmitField section
c0436bd 
> Warning: Unknown prop `grid` on <section> tag.
> Remove this prop from the element
@radekmie
Copy link
Contributor

radekmie commented Aug 4, 2016 •
edited
Loading

Since #64 (see this comment), there's a filterDOMProps helper - it should be used here (grid is already registered here). Example.

I'll add it to README later.

@radekmie radekmie added the Type: Bug Bug reports and their fixes label Aug 4, 2016
@zeroasterisk
Bootstrap packages using filterDOMProps(props)
83f0cff 
This is a handy little function - thanks!
@zeroasterisk
Copy link
Contributor Author

updated, thanks!

radekmie
radekmie reviewed Aug 5, 2016
View reviewed changes
packages/uniforms-bootstrap3/src/components/fields/ErrorsField.js
@@ -5,7 +5,7 @@ import {nothing} from 'uniforms';

const ErrorsField = ({className, children, ...props}, {uniforms: {error, schema}}) =>
(!error && !children) ? nothing : (
<section className={classnames('panel panel-danger', className)} {...props}>
<section className={classnames('panel panel-danger', className)} {...filterDOMProps(props)}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You haven't imported this helper - ESlint fails.

radekmie added a commit that referenced this pull request Aug 5, 2016
@radekmie
Removed remaining extraneous props (#89).
e40c55a
@radekmie
Copy link
Contributor

radekmie commented Aug 5, 2016

I've continued your PR and done it also in semantic and unstyled packages. Thanks for pointing it out!

@radekmie radekmie closed this Aug 5, 2016
@radekmie radekmie changed the title Removed ...props from SubmitField section Fixed additional props warning Sep 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Bug Bug reports and their fixes
Projects
Open Source
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zeroasterisk @radekmie